Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid confusion around blockTypes/allowedBlockTypes/enabledBlockTypes setting #6069

Merged
merged 3 commits into from
Apr 10, 2018
Merged

Avoid confusion around blockTypes/allowedBlockTypes/enabledBlockTypes setting #6069

merged 3 commits into from
Apr 10, 2018

Commits on Apr 9, 2018

  1. Make getInserterItems() require its enabledBlockTypes argument 

    Having this argument optional implies that it's safe to not provide one,
when in reality that will probably result in a bug.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    8e8f241 View commit details
    Browse the repository at this point in the history

  2. Rename enabledBlockTypes and blockTypes to allowedBlockTypes 

    Using the same name for this feature throughout the codebase will
hopefully help developers search for it and better understand it.
    @noisysocks
    noisysocks committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    e68a0a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2018

  1. Update deprecated.md to reflect allowedBlockTypes being made mandatory

    @noisysocks
    noisysocks committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    d1ee410 View commit details
    Browse the repository at this point in the history