-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: Backport fixes from Core #59903
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking care of that 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed these ports and the changes look correct. Thanks!
false !== $result || | ||
( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false !== $result || | |
( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) | |
false !== $result || | |
( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
is_bool( $result ) && | ||
( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_bool( $result ) && | |
( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) | |
is_bool( $result ) && | |
( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
@sirreal I'm removing the backport label as is used to indicate that the backport is needed, not done. 😄 |
* Add mode to directive processing * Add WordPress#59886 wp-develop fix * Add WordPress#6251 fix * Fix linter * Include WordPress#6261 wp-develop * Fix spacing Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
What?
Backports fixes done in Core to the Gutenberg compat folder: