-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity Router: Replace data-wp-navigation-id
with data-wp-router-region
#58191
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/blocks/render-query-test.php |
Size Change: -45 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍️
Flaky tests detected in fe2c923. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7645920452
|
77fd926
to
fe2c923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What?
Tracking issue: #56803
Created on top of #57924
Replaces all the
data-wp-navigation-id
directives withdata-wp-router-region
.The PR also adds a minor refactor to the Query block's focus logic.
Why?
We changed the name to something more appropriate and related to the new
@wordpress/interactivity-router
package.Testing Instructions
Ensure the Query block works as expected with the "Force page reload" option disabled.