Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to manually set image dimensions #5812

Merged
merged 12 commits into from
Apr 18, 2018
Merged

Commits on Apr 16, 2018

  1. Add ability to manually set image dimensions

    Let users manually set the width and height of an image either using a
    text field or by a preset percentage amount.
    noisysocks committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    e593b31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08dec8b View commit details
    Browse the repository at this point in the history
  3. Add explicit height to the editor image only

    The resizing tools we use size a parent div on the image. The height:
    auto responsive CSS we inherit from up higher messes with this. So this
    push adds an explicit 100% height on resized images.
    
    Co-authored-by: Joen Asmussen <joen@automattic.com>
    noisysocks and jasmussen committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    c06aecd View commit details
    Browse the repository at this point in the history
  4. Fix Safari misaligning width/height placeholders

    Setting an explicit line height on the width and height text fields
    prevents a small visual bug in Safari where the fields flicker when a
    number is typed in.
    noisysocks committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    c139fae View commit details
    Browse the repository at this point in the history
  5. Fix paragraph and image inspector control margins

    - Fixes Reset button being too tall on mobile in the paragraph and image
      inspectors
    - Makes the margin at bottom of a <ButtonGroup> consistent with all
      other controls (1em)
    - Fix regression causing width and height fields from being too close to
      each other
    noisysocks committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    bdf94cd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    43c6e08 View commit details
    Browse the repository at this point in the history
  7. Don't set inline styles on an image's <figure>

    Let the <figure> get its width from the fit-content rule that was added
    in 2dc9fb3.
    noisysocks committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    0fd7a95 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    33a4bed View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. Configuration menu
    Copy the full SHA
    9674199 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18e4e92 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfd6d55 View commit details
    Browse the repository at this point in the history
  4. Reset any set image dimensions when image is changed

    If the user selects a new image, forget any image dimensions that they
    added since it likely no longer makes any sense.
    noisysocks committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    af073ab View commit details
    Browse the repository at this point in the history