Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image block align none control #558

Merged
merged 2 commits into from
May 3, 2017
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 28, 2017

Closes #545

This pull request seeks to remove the "Align None" image control. The image controls already behave as toggles, so unsetting alignment back to "none" is a matter of clicking the selected option once more.

Before After
Before After

Testing instructions:

Verify that there is no "Align None" option shown in the controls toolbar when selecting an image block, and that you can still restore the "none" alignment by toggling any active alignment.

@aduth aduth added the [Feature] Blocks Overall functionality of blocks label Apr 28, 2017
@BE-Webdesign
Copy link
Contributor

BE-Webdesign commented Apr 28, 2017

Looks good to me. Merge? Is there any reason why originally align-none was introduced in the WP Editor? I tried to search for its introduction in trac but was unable to find any context in the ticket https://core.trac.wordpress.org/ticket/30147. Seems it was added for accessibility?

@aduth
Copy link
Member Author

aduth commented May 1, 2017

Is there any reason why originally align-none was introduced in the WP Editor? I tried to search for its introduction in trac but was unable to find any context in the ticket https://core.trac.wordpress.org/ticket/30147. Seems it was added for accessibility?

Good find on context. cc @iseulde @azaozz @afercia having been involved in the original discussion. To the point of accessibility, so long as the toolbar can be navigated with a keyboard and the alignment buttons behave as a toggle, I don't really see the need for a standalone "None" control? Unless it's difficult to make clear the behavior of the toggle as resetting back to None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants