-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update page title when using enhanced pagination in query loop. #55446
Fix: Update page title when using enhanced pagination in query loop. #55446
Conversation
Size Change: +29 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
Flaky tests detected in 10cddb4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6585212096
|
8a4e66d
to
c734d75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Some changes need to be addressed, but they're pretty straightforward.
PS: Don't forget to fix the changelog as well! 😁
c734d75
to
10cddb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, @c4rl0sbr4v0. 😊
Cherry-picked for inclusion in 6.4 in 0d36390. |
What?
Update the Document Title when the enhanced pagination is enabled on the Query Loop.
Why?
User experience :-).
To simulate a navigation, we should update page title, page description, and meta tags.
How?
By adding the tittle to the Interactivity API router.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2023-10-18.at.13.22.21.mov