WIP: Only send one class name to HTML API's add_class()
#54873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added
[Type] Enhancement
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
dmsnell
force-pushed
the
html-api-refactor/block-library-search--only-one-class-name
branch
2 times, most recently
from
2a3eb52
to
9217133
Compare
Previously the search block has been passing multiple escaped CSS class names to `add_class()` when the API only expects a single one. For example, `add_class( 'one-class another-class' )`. This has mostly worked, but exposes a bug and ideally the code should match the expectations of the API. In the future, `add_class()` will reject these calls. In this patch we're updating the search block code to only pass in a single class name. This also involves some refactoring to return class names from helper functions in a structured form. By doing this additional work we can avoid joining a string just to split it apart immediately aftwards. Because the HTML API handled escaping, extraneous calls to `esc_attr` have been removed.
dmsnell
force-pushed
the
html-api-refactor/block-library-search--only-one-class-name
branch
from
9217133
to
f4cd8ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the search block has been passing multiple escaped CSS class names to
add_class()when the API only expects a single one.For example,
add_class( 'one-class another-class' ).This has mostly worked, but exposes a bug and ideally the code should match the expectations of the API. In the future,
add_class()will reject these calls.In this patch we're updating the search block code to only pass in a single class name. This also involves some refactoring to return class names from helper functions in a structured form. By doing this additional work we can avoid joining a string just to split it apart immediately aftwards. Because the HTML API handled escaping, extraneous calls to
esc_attrhave been removed.What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast