-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostSyncStatus: Derive sync status inside the selector #54159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Editor
/packages/editor
labels
Sep 4, 2023
Size Change: -15 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for tidying this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates
PostSyncStatus
to derive sync status inside the selector.Why?
It's good practice for components to select only the data they need. In this case, it's better to derive status inside the selector and return string value instead of the whole post meta object.
P.S. The Component occasionally triggered a new
useSelect
warning, meaning thatgetEditedPostAttribute( 'meta' )
might not return a referentially stable object. I'm investigating this separately.Testing Instructions
The component should work as before. I used testing instructions from #52352.
Screenshots or screencast