Perf Tests: Update base point to compare #54111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Task
dmsnell
reviewed
Sep 1, 2023
| @@ -66,13 +66,13 @@ jobs: | |||
| - name: Compare performance with base branch | |||
| if: github.event_name == 'push' | |||
| # The base hash used here need to be a commit that is compatible with the current WP version | |||
| # The current one is 34af5829ac9edb31833167ff6a3b51bea982999c and it needs to be updated every WP major release. | |||
| # The current one is bd2a881101727b03b0be09382b34841af5a3c03e and it needs to be updated every WP major release. | |||
There was a problem hiding this comment.
how'd we come up with this commit SHA?
Block Supports: Change prefix in gutenberg_apply_colors_support to wp_ in dynamic blocks (#51989)
There was a problem hiding this comment.
nevermind I see the answer in the PR description. though I'm still curious: is that WP beta1? GB beta 1?
There was a problem hiding this comment.
WP 6.3 beta 1. We don’t do beta releases for the plugin.
dmsnell
approved these changes
Sep 1, 2023
|
@dmsnell, to be honest it’s was “random” pick. I believe we can’t use SHA from the release branch as it breaks codevitals (See #51689) and can’t pick more recent backport SHAs since there will be changes not included in WP 6.3. As I mentioned in then issue we need to document this step. My current change is based on previous PRs. |
mikachan
added
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #54107.
PR updates the base commit for performance tests.
Why?
The commit needs to be compatible with the current WP version.
How?
I checked previous PRs for the same task (#51381, #51689) and used my best judgment:
Testing Instructions
I think we need to merge this to test on the trunk properly.