Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: Support for the
data-wp-key
directive #53844Interactivity API: Support for the
data-wp-key
directive #53844Changes from 6 commits
76a63a1
c067612
b0017ce
6545b5e
6c9dfb4
aa08d7d
9dd4ff1
5ca3702
cae548c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 6 in packages/e2e-tests/plugins/interactive-blocks/directive-key/render.php
GitHub Actions / PHP coding standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any example we can add here to understand better the value of
data-wp-key
? I mean, some example that actually rearranges elements, insert them or remove them where having a key is essential.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I think it's useful only when doing client-side navigation. So maybe we can add that in #53733.
Ok, that makes sense. If you don't mind, let's merge this as it is because it's merged against #53733, and let's add a better example of
data-wp-key
in the docs for that PR.