-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: remove the wp-show
directive temporarily
#53240
Conversation
Size Change: +227 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Flaky tests detected in 58f4424. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5736594261
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
wp-show
directivewp-show
directive temporarily
What?
Remove the
wp-show
directive temporarily.Why?
Because the final implementation is not clear yet, and it doesn't have server-side rendering support yet.
How?
Just remove the directive from the runtime, remove its e2e tests, and create a
wp-show-mock
directive for the e2e tests that were using it to test when things are removed from the DOM.