Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move request utils reset to global setup #52412

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

swissspidy
Copy link
Member

What?

Moves the "reset" logic from the request utils setup to global setup, wehre it belongs.

Fixes #50741
Fixes #52339

Why?

Right now the request utils in e2e-test-utils-playwright contain a lot of Gutenberg-specific logic that does not apply to other setups.

That means everyone trying to use the utils gets errors about things like the gutenberg-test-plugin-disables-the-css-animations plugin or the twentytwentyone theme not existing.

This logic is an ideal candidate for global setup in Playwright.

How?

Testing Instructions

tests should pass

Testing Instructions for Keyboard

Screenshots or screencast

@swissspidy swissspidy added the [Package] E2E Test Utils /packages/e2e-test-utils label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Flaky tests detected in 42cefe4.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5485130687
📝 Reported issues:

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @swissspidy!

@swissspidy swissspidy merged commit 0d00717 into trunk Jul 13, 2023
49 checks passed
@swissspidy swissspidy deleted the fix/request-utils branch July 13, 2023 19:29
@github-actions github-actions bot added this to the Gutenberg 16.3 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Test Utils /packages/e2e-test-utils
Projects
None yet
2 participants