Top Toolbar: Move the preferences selection into the main useSelect #52332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
Mamaduka
requested changes
Jul 5, 2023
There was a problem hiding this comment.
One selector remains in the edit site package.
gutenberg/packages/edit-site/src/components/header-edit-mode/index.js
Lines 111 to 112 in 60a6c2d
|
One last nitpick: Do you mind replacing other two instances of |
|
Size Change: +20 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cb7fb40. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5465497014
|
|
A rebasing should resolve failing CI checks. |
scruffian
requested review from
spacedmonkey,
noahtallen,
ObliviousHarmony,
t-hamano,
ellatrix,
fluiddot,
dcalhoun,
gziolo,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
kevin940726 and
ntwb
as code owners
scruffian
requested review from
nerrad,
ryanwelcher,
luisherranz,
DAreRodz,
noisysocks,
tellthemachines,
adamziel,
dmsnell,
atimmer,
michalczaplinski,
mmtr,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
scruffian
force-pushed
the
fix/top-toolbar-use-select
branch
from
24715ce
to
e925510
Compare
mburridge
added
[Package] Components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This moves the hasFixedToolbar select inside the main useSelect, as raised in #52123 (comment).
Why?
So that when the fixedToolbar preference value changes, the component will rerender.
How?
Refactoring.
Testing Instructions
Check that changing the top toolbar setting still changes the display of the block toolbars.