Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom patterns console error #51947

Merged
merged 12 commits into from
Jun 28, 2023
Merged

Fix custom patterns console error #51947

merged 12 commits into from
Jun 28, 2023
+104 −102

Commits on Jun 28, 2023

  1. Fix error with react list key with new custom patterns list in inserter

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e75b15c View commit details
    Browse the repository at this point in the history

  2. Update placeholder key

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    4d5a286 View commit details
    Browse the repository at this point in the history

  3. Add comment to explain the different keys

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    fe6bbb5 View commit details
    Browse the repository at this point in the history

  4. Patterns: Fix missing custom patterns in patterns explorer (#51889) 

    * Add custom patterns to pattern explorer

* show custom patterns in the patterns explorer dialog

* remove changes from 51877

* Fix up use of async lists

* remove a bit of code duplication by adding a new hook

* add 51877 fix back to make testing easier
    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7492f24 View commit details
    Browse the repository at this point in the history

  5. Just assign the key value in one place

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    476f805 View commit details
    Browse the repository at this point in the history

  6. Refactor the custom patterns to use the usePatternsState hook

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    607e339 View commit details
    Browse the repository at this point in the history

  7. Fix use of async list

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    6fba2ee View commit details
    Browse the repository at this point in the history

  8. Translate strings and remove unneeded fields from pattern object

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d42efb2 View commit details
    Browse the repository at this point in the history

  9. Try integrating unsynced patterns directly into pattern selectors (#5… 

    …1955)
    @talldan
    talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    dfbb15d View commit details
    Browse the repository at this point in the history

  10. Include reusable blocks with an undefined sync status in inserter items

    @talldan
    talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a2bbc29 View commit details
    Browse the repository at this point in the history

  11. Update docs

    @talldan
    talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    477f533 View commit details
    Browse the repository at this point in the history

  12. Remove change to hover dependencies

    @talldan
    talldan committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    62b0996 View commit details
    Browse the repository at this point in the history