Fix back button tooltip #51725
Merged
Fix back button tooltip #51725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -3 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 07eca49044ca377a67e5f9ba8fa445c7e6c2a57b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5331419262
|
jasmussen
force-pushed
the
try/fix-back-button-tooltip
branch
from
07eca49
to
02070ff
Compare
|
This PR introduces a regression, as the toottip was made visible for accessibility reasons in #49657 / #49659 Icon buttons must always visually expose their accessible name. Tooltips have this specific purpose. The fact that when clicking with the mouse the tooltip looks somehow 'disconnected' from the button is because there's no visible focus style. When navigating the menu and a new level is displayed, the back button receives focus. Since it is focused, it is expected that it shows a focus style and a tooltip. Instead, this expected behavior is altered because of visual reasons:
Probbly, the best solution would be to not set focus on the Back button when navigating, in the first place. Focus should always go to a meaningful place but not unexpectedly alter other aspects of the UI. I see there's a broader ongoing discussion now on #51762 and a better solution could be implemented byt not setting focus on the back button, see #51762 (comment) I'd encourage to opt for that approach. Lastly, I'd like to kindly as to mark an issue or PR with the accessibility label when it touces important accessibility features like focus, tooltips, and the like. Thanks. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue where when navigating the site view, the a "Back" tooltip sits around the back button despite the mouse being nowhere near:
Why?
To add consistency with Global Styles:
Here's after:
Testing Instructions
Test navigating the site view and observe that tooltips lingering.