Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve (and relax) search vs direct URL entry detection in Link Control #51011

Merged
merged 10 commits into from
Jun 6, 2023
Merged

Improve (and relax) search vs direct URL entry detection in Link Control #51011

merged 10 commits into from
Jun 6, 2023

Commits on Jun 6, 2023

  1. Restirct what matches as potentially being a “url”

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    d4c4f8d View commit details
    Browse the repository at this point in the history

  2. Remove direct entry results from coming up in entity search suggestions

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8c9d7ec View commit details
    Browse the repository at this point in the history

  3. Make is-url-like stricter

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    1c0a55f View commit details
    Browse the repository at this point in the history

  4. Add initial tests for isURLLike

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    42fe981 View commit details
    Browse the repository at this point in the history

  5. Improve code with tests and adding check for TLDs

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b0777c0 View commit details
    Browse the repository at this point in the history

  6. Simply implementation

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    c30d995 View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    45dca15 View commit details
    Browse the repository at this point in the history

  8. Test for only showing URL result when searching for URL like

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    ca177f5 View commit details
    Browse the repository at this point in the history

  9. Improve test criteria for URL-like in tests

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b0e07c7 View commit details
    Browse the repository at this point in the history

  10. Augment tests for entity search

    @getdave
    getdave committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    3d43b28 View commit details
    Browse the repository at this point in the history