Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin release docs: Multiple changes #50922

Closed
wants to merge 4 commits into from
Closed

Conversation

bph
Copy link
Contributor

@bph bph commented May 24, 2023

  • Adds cherry picking via npm command + screenshot
  • adds more changelog curation details and moves it to the RC section.

Fixes: #50343 #49884 #42516

Why?

Streamline the process, better onboard new contributors and update on the process.

Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Birgit. Rather than expanding the documentation, we should aim at simplifying it. Currently, it kind of feels overwhelming for first-timers, as it feels like one should read and understand the whole documentation to wrangle a release. In contrast, some of it (e.g., cherry-picking) only needs to be consulted on a need-to-know basis.

For starters, apart from shortening information about the launch process itself (it's just a GitHub action), we should further divide the document into sections and add a Table of Content on top. This can be done in follow-up PRs, though.

docs/contributors/code/release.md Outdated Show resolved Hide resolved
@@ -47,16 +47,51 @@ This message is misleading and no action is required by the release coordinator.

As soon as the workflow has finished, you'll find the release draft under [Gutenberg Releases](https://github.com/WordPress/gutenberg/releases). The draft is pre-populated with changelog entries based on previous release candidates for this version and any changes that have since been cherry-picked to the release branch. Thus, when releasing the first stable version of a series, delete any RC version headers (that are only there for your information) and move the more recent changes to the correct section (see below).

The changelog draft will be partially pre-organized (based on GitHub labels) into sections and, within those, into “features.” Take some time to read the generated notes and then edit them to ensure legibility and accuracy.
## Streamline curating the release changelog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section could be split into more digestible, smaller ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have:

  • Review of Milestone Labels
  • Curating the changelog markdown.
    I will edit it for brevity soon.

@github-actions
Copy link

github-actions bot commented May 24, 2023

Flaky tests detected in f54da5d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5081589052
📝 Reported issues:

@bph
Copy link
Contributor Author

bph commented May 25, 2023

@priethor Thanks for reviewing the draft PR.

There are things that don't take any effort at all, like the workflow. They still need to be explained and are covered. Some things take a lot of time if want to make the most of the time spent and have a good outcome, like curating the changelog and creating the release post.

Now, it would probably be helpful if we create the release documentation following the issue checklist. So each item that needs some explanation, is covered, in the order it's worked on.

@priethor
Copy link
Contributor

Now, it would probably be helpful if we create the release documentation #50970. So each item that needs some explanation, is covered, in the order it's worked on.

I like that idea!

@bph
Copy link
Contributor Author

bph commented Jun 22, 2023

@ndiego and I are continuing our work on Google Docs for now.

@bph
Copy link
Contributor Author

bph commented Jul 26, 2023

Closed as replaced by #52955

@bph bph closed this Jul 26, 2023
@bph bph deleted the docs/gutenberg-release branch July 26, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin release documentation
2 participants