Navigation: Handle empty menus in Navigation Browse Mode. #50870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Navigation in Site View
|
Size Change: +28 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
scruffian
reviewed
May 23, 2023
| return ( | ||
| <SidebarNavigationScreenWrapper | ||
| title={ decodeEntities( menuTitle ) } | ||
| description={ __( 'This Navigation Menu is empty.' ) } |
There was a problem hiding this comment.
Suggested change
| description={ __( 'This Navigation Menu is empty.' ) } | |
| description={ __( 'This Navigation menu is empty.' ) } |
Elsewhere we used Navigation menu.
cbravobernal
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Shows an appropriate message if a menu has no items. Note we cannot add items here because we agreed that this mode would have no edit functionality.
Why?
Just showing blank panel to users is bad.
How?
Check if the entity has any
content. If not then there are no blocks and thus the menu is empty. Show an appropriate message.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast