Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/wp get global styles for custom props returns internal variable #50366

Merged
merged 11 commits into from
May 10, 2023
Merged

Fix/wp get global styles for custom props returns internal variable #50366

merged 11 commits into from
May 10, 2023

Commits on May 9, 2023

  1. Extract logic that converts internal props to css variables 

    The logic that converts internal css variables to custom css
variables is extracted to a function
    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    5a53d35 View commit details
    Browse the repository at this point in the history

  2. Convert the internal css variables to css custom variables

    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    de1f077 View commit details
    Browse the repository at this point in the history

  3. Add test to assert internal css syntax is converted to CSS variable

    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    02fb5c2 View commit details
    Browse the repository at this point in the history

  4. Define gutenberg_get_global_styles and update usages 

    As of the changes to WP_Theme_JSON_Resolver_Gutenberg,
this function had to get defined to keep in sync with core
    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    b4b0823 View commit details
    Browse the repository at this point in the history

  5. Make sure variation styles are includes when sanitizing

    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    b035fb6 View commit details
    Browse the repository at this point in the history

  6. Add correct since annotation to gutenberg_get_global_styles 

    Co-authored-by: André <583546+oandregal@users.noreply.github.com>
    @samnajian @oandregal
    samnajian and oandregal committed May 9, 2023
    Configuration menu
    Copy the full SHA
    9564374 View commit details
    Browse the repository at this point in the history

  7. Add descriptive since annotation to gutenberg_get_global_styles

    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a6b0e78 View commit details
    Browse the repository at this point in the history

  8. Remove usage of convert_custom_properties from get_property_value 

    Since convert_custom_properties is applied in constructor
the other methods don't need to apply it again
    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a19f470 View commit details
    Browse the repository at this point in the history

  9. Apply improvements suggested in PR review

    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    1250ec9 View commit details
    Browse the repository at this point in the history

  10. Simplify sanitize_variables and update usage 

    Since the data is already checked against the schema
sanitize_variables doesn't need to know about the schema
anymore
    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    5833401 View commit details
    Browse the repository at this point in the history

  11. Rename sanitize_variables to resolve_custom_css_format

    @samnajian
    samnajian committed May 9, 2023
    Configuration menu
    Copy the full SHA
    92ed17b View commit details
    Browse the repository at this point in the history