Fix editor canvas detaching error in e2e tests #49374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Bug
draganescu
approved these changes
Mar 28, 2023
|
@kevin940726, tests seem to be failing on CI, you can see inline comments on the files tab. |
kevin940726
force-pushed
the
fix/editor-canvas-frame-locator
branch
from
8df2920
to
b3a7952
Compare
|
@Mamaduka Oops, yep, I'll fix them! Thanks! |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
@kevin940726, maybe we should use the method from #49203 to enter editing mode using query args for the templates parts tests where it makes sense. Then we can have a separate test for the site editor to confirm that clicking on the body works. I know that this doesn't solve the frame getting detached, but in the context of these tests might make more sense. P.S. I might have a branch locally where I started updating tests. |
I 100% agree. Let's go for that!
This is still an issue though, and it's causing some other flakinesses. I need to come up with a better way that's stable but also ergonomically easy-to-use (doesn't require a separate |
kevin940726
force-pushed
the
fix/editor-canvas-frame-locator
branch
from
b3a7952
to
7aff89a
Compare
|
@kevin940726, I think the latest approach worked 🎉 I restarted the tests to be sure, but we can go with this universal fix. |
bph
added
the
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
For some reason that I don't know yet, the editor canvas in the site editor will detach and attach itself on the first load. It's likely caused by a recent commit because it was not happening before for me. This however causes some e2e tests to be flaky because the original
frame( 'editor-canvas' )gets detached. This can be reproduced consistently locally but only intermittently on CI.Why?
To fix flaky e2e tests and unblock local testing. I think this is related to #49203 (c.c. @Mamaduka). Should also fix #48504.
How?
Wait for the body to be loaded in
visitSiteEditor.Testing Instructions
CI should pass.