Add test for useConstrainedTabbing #48736
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: in the next days I won't be able to do any work on this. If anyone has time and passion for testing, please do feel free to go ahead and make this PR yours. ❤️ |
|
Size Change: +881 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5873b77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4499234811
|
afercia
force-pushed
the
add/use-constrained-tabbing-test
branch
from
08e90b0
to
3265482
Compare
|
I'm having some troubles to test this and would greatly appreciate some help. Cc @ellatrix To my understanding, due to the particular implementation of
The above logic appears to be a bit hard to test. To my understanding it's in part a timing issue and in part because of the way the React testing library
I'm not that familiar with the React testing library and I'm out of ideas. Not sure how to make these tests work. Any help is very welcome. On a related note, i'd like to stress the importance of testing |
|
I would need some help to check if the current code is actually testable. @Mamaduka not sure if you have some time but I'd greatly appreciate your help, is possible 🙏 See my last comment: #48736 (comment) If the current implementation of |
|
Thanks for the ping, @afercia! I am adding this to my todo list and will try to provide feedback at the end of this week or early next. |
Mamaduka
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47427
What?
This PR seeks to add tests for
useConstrainedTabbing.For now, it's a draft as I'm unclear how to solve some issues. I'd greatly appreciate any jelp and feedback. Cc @ellatrix
event.keycodeso I had to change the hook to useevent.code.trapelement is focused and then blurred, the actual focus goes to the first tabbable element within the node.Why?
Right now, there's no unit tests for
useConstrainedTabbing. Such an important component should have at least some basic tests.How?
Add tests.
Testing Instructions
Run the test:
npm run test:unit -- --testPathPattern packages/compose/src/hooks/use-constrained-tabbing/test/index.jsTesting Instructions for Keyboard
Screenshots or screencast