Rich text: try removing store change on focus #48342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +198 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 83119aa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4254673746
|
ellatrix
commented
Feb 23, 2023
| @@ -106,7 +110,7 @@ export function useInputRules( props ) { | |||
| } | |||
|
|
|||
| if ( __unstableAllowPrefixTransformations && inputRule ) { | |||
| inputRule(); | |||
| if ( inputRule() ) return; | |||
There was a problem hiding this comment.
This is probably not needed for this PR, but still good to return here.
ellatrix
commented
Feb 23, 2023
| @@ -86,9 +88,11 @@ export function useInputRules( props ) { | |||
| } ); | |||
| const block = transformation.transform( content ); | |||
|
|
|||
| selectionChange( findSelection( [ block ] ) ); | |||
| selectionChange( ...findSelection( [ block ] ) ); | |||
There was a problem hiding this comment.
The reason this fixes the failing test is because we preset selection in the store after replacing the input rule. So when the new block is created, the selection is already correct at the time of the focus event.
youknowriad
reviewed
Feb 23, 2023
| @@ -287,7 +287,6 @@ export function useInputAndSelection( props ) { | |||
| end: index, | |||
| activeFormats: EMPTY_ACTIVE_FORMATS, | |||
| }; | |||
| onSelectionChange( index, index ); | |||
There was a problem hiding this comment.
So this should be a small (maybe not noticeable) perf improvement, right?
There was a problem hiding this comment.
It's a huge improvement for focus:
┌──────────────────────┬──────────────────────────────────────────┬──────────────┐
│ (index) │ fec7ea5acdf2c45e0ecbab96200aa945eb8daed5 │ trunk │
├──────────────────────┼──────────────────────────────────────────┼──────────────┤
│ focus │ '0.27 ms' │ '32.6 ms' │
│ minFocus │ '0.24 ms' │ '0.41 ms' │
│ maxFocus │ '0.36 ms' │ '48.82 ms' │
There was a problem hiding this comment.
Maybe we should update the metric though. It feels now that we should be computing "focus + selection change". It seems the time has moved to another event that we don't take into consideration in the metric itself?
youknowriad
approved these changes
Feb 23, 2023
ellatrix
force-pushed
the
try/rich-text-on-focus-store-change
branch
from
d71b8a6
to
150f638
Compare
ellatrix
commented
Feb 23, 2023
| @@ -89,7 +89,7 @@ export default function getRectangleFromRange( range ) { | |||
| // by adding a temporary text node with zero-width space to the range. | |||
| // | |||
| // See: https://stackoverflow.com/a/6847328/995445 | |||
| if ( ! rect ) { | |||
| if ( ! rect || rect.height === 0 ) { | |||
There was a problem hiding this comment.
Ranges set by Firefox might have 0 height (when it's collapsed on an empty string). This PR probably changes something where we're overriding the range set by Firefox, which is fine.
|
So as you can see in the performance metrics, simply adding It's still one |
mcsf
reviewed
Feb 24, 2023
Comment on lines
+254
to
+256
| allDurations.reduce( ( acc, eventDurations ) => { | ||
| return acc + sum( eventDurations ); | ||
| }, 0 ) |
There was a problem hiding this comment.
This smells like it should be
sum( allDurations.map( sum ) )No?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #44304. Just want to see e2e test results.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast