Migrate list view E2E tests to Playwright #47919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +15 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3b1f5e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4156284101
|
WunderBart
force-pushed
the
migrate/playwright-list-view
branch
5 times, most recently
from
01ea80b
to
341056d
Compare
|
@WunderBart #45135 will likely get merged in soon, will this hurt your efforts? |
WunderBart
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
reviewed
Feb 10, 2023
Mamaduka
reviewed
Feb 10, 2023
kevin940726
reviewed
Feb 10, 2023
Looks like it will, @alexstine! Thanks for the heads up, I'll keep an eye on that PR. 👍 |
WunderBart
force-pushed
the
migrate/playwright-list-view
branch
from
1891141
to
3b1f5e5
Compare
WunderBart
added
[Type] Automated Testing
|
@kevin940726 @Mamaduka, it's ready for another go! 🙌 |
kevin940726
approved these changes
Feb 12, 2023
|
@alexstine, this one's ready to be shipped. Let me know if I should wait for #45135 – I don't want to block you, in case you're ready as well. |
Don't do it if it's unnecessary for the test to pass as it increases the fragility by bringing another selector into the equation.
Dragged the wrong thing by mistake :)
This reverts commit e91096e.
This reverts commit 23d9daf.
If the error is actually thrown, the preceding assertion that checks the number of List View items will catch it.
WunderBart
force-pushed
the
migrate/playwright-list-view
branch
from
3b1f5e5
to
4dd325f
Compare
|
@alexstine, I've migrated the test you've added in #45135. Let me know if it looks good to you! |
|
@WunderBart I am sure it is fine. The code diffs are a bit too much for me to check in this PR. I imagine these tests will likely change in the future as the list view itself needs some adjustments after discovery of a couple random focus bugs. Thanks. |
|
@WunderBart Just wanted to see if you are merging this one soon? I am working on more list view improvements which could use E2E tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrate List View E2E tests to Playwright.
Why?
How?
Testing Instructions
The output of the following should be all ✅: