Fix broken Link Control hook #46113
Merged
Fix broken Link Control hook #46113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Regression
getdave
requested review from
scruffian,
MaggieCabrera,
ajlende and
draganescu
|
Size Change: -3 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
getdave
commented
Nov 28, 2022
packages/block-editor/src/components/link-control/use-internal-input-value.js
Outdated
Show resolved
Hide resolved
|
With this PR I see this in the site editor:
|
I tested this in the Site Editor and could not replicate that.
🙇 |
|
I have totally rebuilt and I still see the issue. To replicate, you have to add a link inside a template part. The second pencil icon that appears is a link to edit the template, not the link itself. I'll look into a fix for this now. |
|
I just realised this is an issue on trunk as well. I'll create a separate issue for it. |
|
Issue created here: #46149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the
useInternalInputValuehook to be agnostic of the property it is managing.This was a bug that was accidentally introduced in #37833
Why?
The hook is designed to manage a given value and keep internal state in sync. It was accidentally only managing the
titleproperty of the linkvalueobject.How?
Make the hook able to manage any property provided rather than just
title.Testing Instructions
Screenshots or screencast