Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce experiment for inspector based navigation editing #45515

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Nov 3, 2022

What?

This PR a spin off from #44534.
The base PR was approved but it was too big as a changeset so we're splitting it up.

This PR introduces the experiment setting and checkbox required to build as an experiment a new inspector based editing UX
for the navigation block - based on a list view.

Why?

To develop this new UX in isolation, potetially faster, and enable user validation of the UX.

How?

Copy paste of the zoomed out view setting and checkbox and then change the copy.

Testing Instructions

  1. Go to Gutenberg > Experiments
  2. There should be a new experiment named "Test a new "off canvas" editor for navigation block using the block inspector
    and a tree view of the current menu"

Screenshots or scree ncast

Screenshot 2022-11-03 at 15 27 10

@codesandbox
Copy link

codesandbox bot commented Nov 3, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@draganescu draganescu added [Block] Navigation Affects the Navigation Block [Type] Experimental Experimental feature or API. labels Nov 3, 2022
@draganescu draganescu force-pushed the add/navigation-off-canvas-edit-experiment branch from 599e3f4 to 2c03fd2 Compare November 4, 2022 08:27
@draganescu draganescu closed this Nov 4, 2022
@draganescu draganescu force-pushed the add/navigation-off-canvas-edit-experiment branch from 2c03fd2 to 3c5d618 Compare November 4, 2022 08:34
@draganescu draganescu reopened this Nov 4, 2022
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian scruffian merged commit 1386ec3 into trunk Nov 7, 2022
@scruffian scruffian deleted the add/navigation-off-canvas-edit-experiment branch November 7, 2022 21:19
@github-actions github-actions bot added this to the Gutenberg 14.6 milestone Nov 7, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs User Documentation Needs new user documentation [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants