Latest posts and latest comments: add spacing support #45110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
carolinan
added
[Type] Enhancement
|
Size Change: +225 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
carolinan
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
The latest comments block is rendered by the <ServerSideRender
block="core/latest-comments"
attributes={ attributes }
skipBlockSupportAttributes
urlQueryArgs={ { _locale: 'site' } }
/>Before
After
|
Thank you, I was able to confirm it and I have updated the PR. |
This was referenced Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds margin and padding support to latest comments and latest posts blocks.
Why?
For consistency.
How?
Testing Instructions
Make sure that your test install has both posts and comments.
(For all the spacing changes, make sure that the active theme supports spacing, for example in theme.json).
Create a new posts or page.
Add a latest posts block and a latest comments block.
Confirm that there is a dimension panel, and that the margin and and padding settings are available but not enabled by default.
Test the margin and padding settings for both blocks, in the editor and front.
Bonus: Nest them inside a group block with "Inner blocks use content width" turned off to fully test left and right margins.
Screenshots or screencast