Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Add missing typography support #43542

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography supports to the Navigation block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing letter-spacing typography support.

Testing Instructions

  1. In the site editor, select a navigation block.
  2. Navigate to Global Styles > Blocks > Navigation > Typography
  3. Adjust the letter-spacing value, ensuring it is reflected in both the preview and the frontend.
  4. Switch to the "Settings" sidebar, then select a navigation block.
  5. Adjust the letter-spacing control here and ensure it overrides the global style.
  6. Clear customizations and test that letter spacing can be applied via theme.json

Example theme.json snippet:

			"core/navigation": {
				"typography": {
					"letterSpacing": "3px"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.1.09.47.pm.mp4

Adds letter-spacing support to the navigation block.
@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 24, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 24, 2022
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me:
✅ Letter spacing option appeared in global styles block settings for Navigation block and changes were reflected in site editor, post editor and front end
✅ Changes to letter spacing at block level in post editor were applied in editor and frontend
✅ theme.json setting was reflected in site and post editor and frontend

@aaronrobertshaw aaronrobertshaw merged commit 79f4f9a into trunk Aug 24, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-navigation branch August 24, 2022 05:55
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 24, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants