-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit-post/sidebar/template: Fix lack of context on action buttons and improve A11Y #41615
Conversation
Size Change: +83 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well and the tests are now passing. Approving.
Looks good! Just one thing: the labels should be in "sentence case". See this section of the copy guide and one of our early precedents in this PR from 2019. |
@mcsf Looks better? |
Yes, thank you! |
What?
Adds
aria-label
to the template action buttons Edit/New to provide more context.Why?
Screen reader users rely on context to know that is the action they wish to take. Edit what? New what?
How?
Adds the
aria-label
.Testing Instructions
Screenshots or screencast