Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading block - add font family support #40970

Merged
merged 1 commit into from
May 11, 2022

Conversation

Addison-Stavlo
Copy link
Contributor

Adds __experimentalFontFamily support for the heading block.

For supporting fonts in FSE we need to consider which blocks most require the ability to have different fonts set than the main body. core/site-title and core/post-title both include support for font families.

Similarly, core/heading is a block that would also make sense for this. Generally, this support seems necessary for all blocks that serve the purpose of a title or heading (heading, site title, post title, etc.) to allow the same level of font style customization that was available in pre-FSE customizer themes.

heading-block-fonts

Testing

  • Run this PR
  • Open the global styles panel -> blocks -> heading and verify we are able to select font family.

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense... 👍 Having font-family controls in headings blocks is indeed something needed for designers

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this is a great addition to the heading block.

@aristath
Copy link
Member

3 approvals and no failing tests. I think this is good to merge 👍

@aristath aristath merged commit 4f7f3f9 into trunk May 11, 2022
@aristath aristath deleted the add/font-family-support-to-heading-block branch May 11, 2022 10:11
@github-actions github-actions bot added this to the Gutenberg 13.3 milestone May 11, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block Needs User Documentation Needs new user documentation [Package] Block library /packages/block-library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants