Design tweaks to Post Visibility popover #40530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
7 tasks
|
Size Change: -859 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
It's looking good! There are just a couple of things:
In Firefox it looks correctly.
Screen.Recording.2022-04-22.at.11.07.28.movThis won't be a problem if we end up placing the popovers beside the sidebar, but that's part of another conversation we could have when we are done with the rest of the popovers. |
apeatling
reviewed
Apr 26, 2022
There was a problem hiding this comment.
The padding around the edges of this doesn't look quite right to me when compared to the reference mockup. There needs to be around a 25% reduction around the perimeter, and 50% between the Visibility title and the first line of text:
| Mockup | Current |
|---|---|
 |
 |
Other things I just noticed:
- The text under the title of each item is lighter in color in the mockup -- not sure if this meets accessibility standards?
- The spacing after the radio button is larger in the mockup
- The visibility status titles are bold, but are not in the mockup
|
Thanks for the keen eyes! 👀
👌 Fixed.
👌 I've changed it so that the popover is anchored to the middle of the entire row. This stops it moving around.
👌
The spacing between the radio and the label? It is 12px for me which matches the mockup. |
apeatling
approved these changes
Apr 27, 2022
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A few design tweaks to the Post Visibility popover.
Why?
Part of #39082 which is an effort to refresh the entire Status & Visibility panel. I'm tackling it one popover at a time.
How?
PostVisibilityto use React hooks, because why not.I explored inlining the modal confirmation step that happens after you select Private which is what @javierarce suggests in this Figma file. I decided against this though as it's very difficult to get that flow to work nicely with a screen reader. Let's improve this part of the flow separately—see #9396.
Testing Instructions
trunk.