-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi-selection]: Copy/cut partial selected blocks #40098
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8e7b296
[Multi-selection]: Copy/cut partial selected blocks
ntsekouras 6d50760
handle `copy` button in block actions
ntsekouras 1c3c8a1
merge blocks on cut
ntsekouras b8de1d6
partial copy from block actions only when is mergeable
ntsekouras b035115
update selector
ntsekouras d2bacd5
revert partial selection copy in block actions menu item
ntsekouras e8b0901
add jsdoc for mapRichTextSettings util
ntsekouras 0d20c29
update tests
ntsekouras 65d89b4
add new e2e tests + pressKeyTimes playwright util
ntsekouras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/** | ||
* Helper function that maps attribute definition properties to the | ||
* ones used by RichText utils like `create, toHTMLString, etc..`. | ||
* | ||
* @param {Object} attributeDefinition A block's attribute definition object. | ||
* @return {Object} The mapped object. | ||
*/ | ||
export function mapRichTextSettings( attributeDefinition ) { | ||
ntsekouras marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const { | ||
multiline: multilineTag, | ||
__unstableMultilineWrapperTags: multilineWrapperTags, | ||
__unstablePreserveWhiteSpace: preserveWhiteSpace, | ||
} = attributeDefinition; | ||
return { | ||
multilineTag, | ||
multilineWrapperTags, | ||
preserveWhiteSpace, | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
packages/e2e-test-utils-playwright/src/page/press-key-times.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* Presses the given keyboard key a number of times in sequence. | ||
* | ||
* @param {string} key Key to press. | ||
* @param {number} count Number of times to press. | ||
*/ | ||
export async function pressKeyTimes( key, count ) { | ||
while ( count-- ) { | ||
await this.page.keyboard.press( key ); | ||
} | ||
} |
3 changes: 0 additions & 3 deletions
3
...hots/Copy-cut-paste-of-whole-blocks-should-cut-and-paste-individual-blocks-1-chromium.txt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to handle how merging will be performed(forward or not)? This is defined in other cases explicitly by checking the pressed key(Escape or Delete). Should we decide based on where the selection starts and make this as a target to merge? --cc @mtias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question to raise, but IMO cutting isn't a directional operation in the minds of users. I'd stick with a plain (
isForward: false
) deletion.