Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport changes made to duotone in core #40067

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Backport changes made to duotone in core #40067

merged 1 commit into from
Apr 6, 2022

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Apr 6, 2022

There were a few code changes in duotone.php in core that weren't in the plugin. This backports those changes from core into the plugin.

@ajlende ajlende added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Apr 6, 2022
@ajlende ajlende requested a review from Mamaduka April 6, 2022 01:28
@ajlende ajlende self-assigned this Apr 6, 2022
@ajlende ajlende mentioned this pull request Apr 6, 2022
Closed
36 tasks
Mamaduka
Mamaduka approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @ajlende.

@gziolo gziolo added [Type] Bug An existing feature does not function as intended Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Apr 6, 2022
@gziolo gziolo merged commit 5ef5f90 into trunk Apr 6, 2022
@gziolo gziolo deleted the backport/duotone-core-changes branch April 6, 2022 11:43
@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@ajlende ajlende

Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ajlende @Mamaduka @gziolo