RTL: Flip some dashicons that have directionality #3912
Conversation
`editor-outdent`, `editor-indent`, `list-view`, and `editor-ul` can and should be flipped in RTL `editor-ol` needs an RTL version: WordPress/dashicons#250
components/panel/style.scss
Outdated
| @@ -133,3 +133,14 @@ | |||
| .components-panel .circle-picker { | |||
| padding-bottom: 20px; | |||
| } | |||
|
|
|||
| body.rtl .gutenberg .dashicon { | |||
There was a problem hiding this comment.
this should probably go in a dashicons scss: https://github.com/WordPress/gutenberg/tree/master/components/dashicon
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import './style.scss'; |
There was a problem hiding this comment.
This file is generated, so this import would be overwritten next time the Dashicons is updated. It seems like the RTL flipping could be valuable to have in the base Dashicons repository, but in keeping it generic we'd not want to assume the presence of an .rtl body class. Would it be reasonable to detect RTL from JavaScript inside the component class and apply an inline style?
https://github.com/WordPress/dashicons/blob/master/sources/react/index-header.jsx
https://github.com/WordPress/dashicons/blob/master/sources/react/index-footer.jsx
| @@ -0,0 +1,10 @@ | |||
| body.rtl .gutenberg .dashicon { | |||
| &.dashicons-editor-outdent, | |||
There was a problem hiding this comment.
Mixed whitespace, tabs and spaces.
gziolo
added
the
[Status] Stale
|
@yoavf do you plan to finish this PR or should someone else take it over? |
|
May be just me but... |
|
Closing as stale without response. |
Description
editor-outdent,editor-indent,list-view, andeditor-ulcan and should be flipped in RTL.editor-ol(not taken care of yet) needs an RTL version: RTL version needed for editor-ol dashicons#250How Has This Been Tested?
Manual testing in LTR and RTL mode
Screenshots (jpeg or gifs if applicable):
Before:
After
Types of changes
CSS that will affect the RTL version, and will flip the icons.
Checklist: