Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block: add gap support / block spacing #38164

Merged
merged 22 commits into from
Mar 17, 2022
Merged

Gallery block: add gap support / block spacing #38164

merged 22 commits into from
Mar 17, 2022
+108 −57

Commits on Mar 16, 2022

  1. Try using a custom gallery specific var to calculate image sizes base… 

    …d on gap setting
    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    92d75ab View commit details
    Browse the repository at this point in the history

  2. Add style via same portal as layout styles instead of inline with block

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    895e799 View commit details
    Browse the repository at this point in the history

  3. Add doc comment to new render callback

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    e3ed7e8 View commit details
    Browse the repository at this point in the history

  4. Switch to using the block id as the selector for custom gap property

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f8416a4 View commit details
    Browse the repository at this point in the history

  5. Set default block gap in frontend

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d65734d View commit details
    Browse the repository at this point in the history

  6. Fix issue with block deprecations failing

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    2775050 View commit details
    Browse the repository at this point in the history

  7. Fix linting issue

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    8083ed8 View commit details
    Browse the repository at this point in the history

  8. Only add gap styles on web

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f0332b3 View commit details
    Browse the repository at this point in the history

  9. Only run useContext on web

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1ad43d7 View commit details
    Browse the repository at this point in the history

  10. Move the gap styles to a separate component so easier to load for web… 

    … platform only
    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d62f967 View commit details
    Browse the repository at this point in the history

  11. Don't display empty placeholder div if Gallery block has images

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    7e3ce19 View commit details
    Browse the repository at this point in the history

  12. Return null from GapStyle if no gap or style element set

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d17bb19 View commit details
    Browse the repository at this point in the history

  13. Adding the block_core_gallery_render render callback to the registe… 

    …r function.
    @ramonjd
    ramonjd authored and Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d5a0a8d View commit details
    Browse the repository at this point in the history

  14. Remove the margins on non-cropped images as not needed with move to gap

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    8391b9c View commit details
    Browse the repository at this point in the history

  15. Add margin reset back

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    10b5865 View commit details
    Browse the repository at this point in the history

  16. Add back the block margins that are being reset by the

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    045de4f View commit details
    Browse the repository at this point in the history

  17. Make sure deprecated styles are not applied to new gallery blocks

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f90a2e0 View commit details
    Browse the repository at this point in the history

  18. Remove 0 margin setting from editor css and increase specificity of d… 

    …eprecated css
    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    3be7cbb View commit details
    Browse the repository at this point in the history

  19. Reduce specificity of layout margin reset

    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1bd5330 View commit details
    Browse the repository at this point in the history

  20. Revert "Reduce specificity of layout margin reset" 

    This reverts commit d07a8ed.
    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    c5d6b47 View commit details
    Browse the repository at this point in the history

  21. Change the gap fallback setting from 0.5em to the previous default of… 

    … grid-unit-20 or 16px
    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    9b39cf3 View commit details
    Browse the repository at this point in the history

  22. Revert "Change the gap fallback setting from 0.5em to the previous de… 

    …fault of grid-unit-20 or 16px"

This reverts commit 8a2f8fe.
    Glen Davies committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    c0be8b4 View commit details
    Browse the repository at this point in the history