Gallery block: prototype managing gap changes without css var #38015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Status] In Progress
glendaviesnz
requested review from
ajitbohra,
mkaz and
mkevins
as code owners
|
Size Change: -455 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
glendaviesnz
changed the base branch from
trunk
to
add/gap-support-to-gallery
glendaviesnz
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
|
Closing in favour of #38164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For background see #37903
This PR is just a PoC to look at options for managing gap changes in the Gallery block without resorting to an additional flex layout module css var.
How has this been tested?
Add a gallery in WP env with block theme, add images and adjust block gap.
This PR is not supposed to be 100% functional, it is just an exploration of what is and isn't possible, and it currently only works in editor, not frontend, as the context value used are not available in the save method.
I wouldn't recommend going with this approach as it has the following limitations:
Even though this is not a great way forward I thought it was worth putting up in case it triggered any different approaches from others.