Expose pluralised form of entity label #37828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
changed the title
|
Size Change: -3 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jan 10, 2022
| @@ -217,6 +217,7 @@ async function loadPostTypeEntities() { | |||
| baseURLParams: { context: 'edit' }, | |||
| name, | |||
| label: postType.labels.singular_name, | |||
| labelPlural: postType.labels.name, | |||
There was a problem hiding this comment.
the plural form is already available in postType.name, I don't mind having it here but I think the main problem right now is that the singular label is not available in the request using the "view" context. (The plural is available in all contexts)
There was a problem hiding this comment.
Yeh agree. That's why I don't think we could merge a PR like this until the Types API returns more label information for view context requests.
Honestly I think it should be possible and feasible given that labels are not a sensitive piece of data.
There was a problem hiding this comment.
@spacedmonkey Do you see it as achievable that we could get the Types API endpoint to return full labels information about the Post Type for both view and edit contexts?
|
Closing this out. I don't think it's urgently needed right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in
entities.jswe only access the singular form of the entity label. However when registering a Post Type we provide both singular and plural forms. This plural form comes in handy in many places including when we want to differentiate between singular or multiple copies of an entity.An example of this is the multi-entity saving flow where we want to show the singular or plural form of the entity name depending on the quantity of entities of a given type being saved.
This PR updates the entities to include
labelPluralas well aslabel(singular). It then applies that to the multi-entity saving flow.Note we were already doing this manually for the Template Parts so it makes sense to do it for all entity types.
Please also #37685 which if committed would make this change impossible.
How has this been tested?
PostandNavigation Menu- note the singular form.Navigation Menus- note this is now using the plural form.Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).