Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative: restrict Navigation permissions and show UI warning if cannot create #37454

Merged
merged 24 commits into from
Dec 20, 2021
Merged

Alternative: restrict Navigation permissions and show UI warning if cannot create #37454

merged 24 commits into from
Dec 20, 2021
+202 −89

Commits on Dec 17, 2021

  1. Test for publish abtility and display warning

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    8849edf View commit details
    Browse the repository at this point in the history

  2. Update creation of Nav posts to require admin perms

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    602f812 View commit details
    Browse the repository at this point in the history

  3. Only show menu creation option if user has permission to create

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    86016bc View commit details
    Browse the repository at this point in the history

  4. Move permission selectors to hook

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    dab6f77 View commit details
    Browse the repository at this point in the history

  5. Show warning if unable to create Navigation Menus

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    316b107 View commit details
    Browse the repository at this point in the history

  6. Copy changes from Core patch 

    See https://github.com/WordPress/wordpress-develop/pull/2056/files
    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    2632271 View commit details
    Browse the repository at this point in the history

  7. Only show error if create is not allowed

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    6b440f6 View commit details
    Browse the repository at this point in the history

  8. Revert "Copy changes from Core patch" 

    This reverts commit 1872f62a454dc41ce787103e3d1830f7ff00d63c.
    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    26ed2b2 View commit details
    Browse the repository at this point in the history

  9. Use streamlined permissions 

    Kudos to @spacedmonkey for #37454 (comment)
    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    8efde3d View commit details
    Browse the repository at this point in the history

  10. Remove inline warning and reenable ability to select existing

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    4fd4fc2 View commit details
    Browse the repository at this point in the history

  11. Refactor Notices to reusable hook

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    7ff2e75 View commit details
    Browse the repository at this point in the history

  12. Add notices for creating Menus

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    5745d79 View commit details
    Browse the repository at this point in the history

  13. Rename dep for clarity

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    3bbcffd View commit details
    Browse the repository at this point in the history

  14. Hide other creation options

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    2a56786 View commit details
    Browse the repository at this point in the history

  15. Add e2e test

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    07ccae4 View commit details
    Browse the repository at this point in the history

  16. Hide classic Menus from dropdown 

    See #37454 (comment)
    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    b4a7621 View commit details
    Browse the repository at this point in the history

  17. Fix up e2e tests following changes from rebase

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    8676d2a View commit details
    Browse the repository at this point in the history

  18. Update to make component props more agnostic

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    230b9d9 View commit details
    Browse the repository at this point in the history

  19. Make component props less tighly coupled to permissions

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    a90dc3d View commit details
    Browse the repository at this point in the history

  20. Remove unneeded undefined fallback

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    2d4c890 View commit details
    Browse the repository at this point in the history

  21. Refactor hooks

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    4b630e5 View commit details
    Browse the repository at this point in the history

  22. Try switch user to admin

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    50ccac1 View commit details
    Browse the repository at this point in the history

  23. Try switching back to admin after each permissions test

    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    5c2597e View commit details
    Browse the repository at this point in the history

  24. Try targetting test that relies on avoiding a 404 from URL details en… 

    …dpoint
    @getdave
    getdave committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    4430a51 View commit details
    Browse the repository at this point in the history