Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: How to create block pattern #37424

Conversation

jorgecontreras
Copy link
Contributor

@jorgecontreras jorgecontreras commented Dec 15, 2021

Closes #36688.

Description

Add how to guide to create block pattern using The Good Docs Project template

How has this been tested?

Confirmed all steps are correct by following them on local setup.

Screenshots

Types of changes

Documentation

Checklist:

- Add how to guide to create block pattern based on The Good Docs Project template.
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 15, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jorgecontreras! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@carolinan
Copy link
Contributor

carolinan commented Dec 16, 2021

Thank you for the PR!
I would like to see a little bit more context about assembling the blocks in the editor and copying the code from the editor to the PHP function.
It does not have to be very long.

Perhaps also include how to register a pattern category?

The text in the example code needs to be wrapped inside translation functions.

The image needs to be moved from the external staging site; or perhaps there are already existing images that can be used.
@mkaz may know.

@mkaz
Copy link
Member

mkaz commented Dec 16, 2021

There are also some images and sample code from the News article on Patterns:
https://wordpress.org/news/2021/03/so-you-want-to-make-block-patterns/

It would be fine to use the full URL to the images and keep them directly hosted there.

@skorasaurus
Copy link
Member

Thanks for your work on this. Since your pull request, documentation regarding block patterns has been merged in (https://developer.wordpress.org/block-editor/reference-guides/block-api/block-patterns/) ; making the content in this PR unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs request: How to create a block pattern
4 participants