Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove navigationArea context. #36981

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Remove navigationArea context. #36981

merged 1 commit into from
Nov 29, 2021

Conversation

spacedmonkey
Copy link
Member

Description

Now that navigation areas have been removed, all references to them should also be removed navigation block.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@spacedmonkey spacedmonkey added [Block] Navigation Affects the Navigation Block Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Nov 29, 2021
@spacedmonkey spacedmonkey self-assigned this Nov 29, 2021
@spacedmonkey spacedmonkey mentioned this pull request Nov 29, 2021
Closed
@noisysocks noisysocks merged commit 2b92c1f into trunk Nov 29, 2021
@noisysocks noisysocks deleted the fix/remove-navigation-1 branch November 29, 2021 23:38
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 29, 2021
noisysocks pushed a commit that referenced this pull request Nov 30, 2021
@spacedmonkey @noisysocks
Remove navigationArea context. (#36981)
89dac2a
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 30, 2021
@noisysocks noisysocks mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellofromtonya hellofromtonya hellofromtonya approved these changes

@adamziel adamziel Awaiting requested review from adamziel

@noisysocks noisysocks Awaiting requested review from noisysocks

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@spacedmonkey spacedmonkey

Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Milestone
Gutenberg 12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @hellofromtonya @noisysocks