Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Failing PHPUnit test #36931

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Fix: Failing PHPUnit test #36931

merged 1 commit into from
Nov 28, 2021

Conversation

Mamaduka
Copy link
Member

Description

Fixes failing PHPUnit test on trunk. Issue was introduced via #36911, when I forgot to rebase after new test was introduced.

How has this been tested?

Unit PHP test should be passing.

Screenshots

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka self-assigned this Nov 28, 2021
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Nov 28, 2021
@Mamaduka
Copy link
Member Author

I'm going to merge this to unblock development.

@Mamaduka Mamaduka merged commit d4a3d02 into trunk Nov 28, 2021
@Mamaduka Mamaduka deleted the fix/failing-phpunit-test branch November 28, 2021 07:51
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 28, 2021
noisysocks pushed a commit that referenced this pull request Nov 29, 2021
@Mamaduka @noisysocks
Fix: Failing PHPUnit test (#36931)
06c9fae
@noisysocks noisysocks mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras Awaiting requested review from ntsekouras

Assignees

@Mamaduka Mamaduka

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 12.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Mamaduka