Offset the parent iframe when computing Popover position #36876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chorRefFallback is used
adamziel
added
[Package] Components
|
Size Change: +1 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
adamziel
requested review from
youknowriad,
ellatrix,
aduth,
david-szabo97 and
epiqueras
adamziel
commented
Nov 25, 2021
adamziel
changed the title
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Offset the parent iframe when computing Popover position even when anchorRefFallback is used * Update packages/components/src/popover/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36634
The problem:
The tooltip is rendered far away from the link:
Root cause:
Site editor is inside of an iframe, and
.popover-slotwhere the Popovers are rendered is outside of the iframe. Popover only offsets the parent iframe position, when it receives either aanchorReforgetAnchorRectproperty, but theTooltipcomponent pass neither.Solution
Call
offsetIframeeven when Popover doesn't receive eitheranchorReforgetAnchorRect, but relies onanchorRefFallback.Test plan
Add a nav block in the s