Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolsPanel: Improve unit tests #35658

Merged
merged 8 commits into from
Oct 19, 2021
Merged

ToolsPanel: Improve unit tests #35658

merged 8 commits into from
Oct 19, 2021

Commits on Oct 15, 2021

  1. Remove use of querySelector from unit tests

    @aaronrobertshaw
    aaronrobertshaw committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    dc2e9a9 View commit details
    Browse the repository at this point in the history

  2. Do not rely on accessing parent node

    @aaronrobertshaw
    aaronrobertshaw committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    8eba6d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Remove class from wrapped panel items in tests

    @aaronrobertshaw
    aaronrobertshaw committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    acd9707 View commit details
    Browse the repository at this point in the history

  2. Merge tests to single general rendering check 

    Now we aren't checking specifically just for the panel container's existence there is overlap with other tests and the benefit of separating individual concerns is lost. For a general overview test it seems ok to merge them.
    @aaronrobertshaw
    aaronrobertshaw committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    451a8c5 View commit details
    Browse the repository at this point in the history

  3. Switch queryByText to getByText 

    After an earlier refactor it was missed that this could be the more direct getByText call instead.
    @aaronrobertshaw
    aaronrobertshaw committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    e463576 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @aaronrobertshaw
    aaronrobertshaw committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    fd49890 View commit details
    Browse the repository at this point in the history

  5. Add a test to cover the check against panelId for callbacks.

    @aaronrobertshaw
    aaronrobertshaw committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    cdd6ce3 View commit details
    Browse the repository at this point in the history

  6. Add link to PR/issue that the previous test covers

    @aaronrobertshaw
    aaronrobertshaw committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    21291a9 View commit details
    Browse the repository at this point in the history