Fixed condition to show separator correctly

[amustaque97]

Description

Modified condition to toggle separator when the current button is active and
showSeparator value is false. This condition will handle both undefined or
any random value which is not present in the toggle-group-control-option.

https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/toggle-group-control/toggle-group-control-button.tsx#L59

How has this been tested?

• Checkout to my PR branch.
• Run storybook using npm run storybook:dev
• Use following code

 <ToggleGroupControl value={undefined} >
    <ToggleGroupControlOption
      key="foo"
      label="foo"
      value="foo"
    />
    <ToggleGroupControlOption
      key="bar"
      label="bar"
      value="bar"
    />
  </ToggleGroupControl>

• Navigate to ToggleGroupControl -> default
• Verify Changes ie it will show separator for all the buttons/options

Screenshots

Types of changes

Bug Fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

related to #35382
cc @ntsekouras

[ntsekouras]

Thanks for working on this @amustaque97 !

I'm afraid the problem has more nuances than this. You can test yourself that the separator is shown always except after the active item. It will be easier to notice if you change this style to something like red: https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/toggle-group-control/styles.ts#L111

This is the function that needs changing and has to do with our checks of currentId and the internal handling of it from Reakit

[ntsekouras]

Thanks for your contribution @amustaque97 🎉
It was a pleasure collaborating with you!