Increase Link UI search results to 10 on Nav Editor screen #34808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
adamziel,
draganescu,
kevin940726,
talldan and
tellthemachines
as code owners
|
@rolf-yoast as we discussed this change. |
|
@javierarce Are you happy with this change from a UI perspective? |
|
Size Change: +12 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 14, 2021
Yes, I think it is a good improvement, @getdave. |
talldan
deleted the
update/nav-editor-link-ui-increased-search-suggestions
branch
talldan
added
[Type] Enhancement
Excellent thinking 👍 |
fullofcaffeine
added a commit
that referenced
this pull request
Sep 16, 2021
* trunk: (74 commits) Update docs for ClipboardButton component (#34711) Post Title Block: add typography formatting options (#31623) Bump plugin version to 11.5.0 Navigation Screen: Adjust header toolbar icon styles (#34833) Fix the parent menu item field in REST API responses (#34835) Rewrite FocusableIframe as hook API (#26753) Create Block: Remove wp-cli callout since not recommended and outdated (#34821) Global Styles: Fix dimensions panel default controls display (#34828) [RNMobile][Embed block] Enable embed preview for Instagram and Vimeo providers (#34563) Increase Link UI search results to 10 on Nav Editor screen (#34808) Prevent welcome guide overflow x scroll (#34713) Enable open on click for Page List inside Navigation. (#34675) [RNMobile] [Embed block] - Unavailable preview fallback bottom sheet title update (#34674) Add missing field _invalid in menu item REST API (#34670) Fix Dropdown/DropdownMenu toggle closing in all UAs (#31170) Navigation submenu block: replace global shortcut event handlers with local ones (#34812) Navigation Screen: Consolidate menu name and switcher (#34786) Remove parent and position validation from menu item REST API endpoint (#34672) Clean theme data when switching themes in the customizer (#34540) Components: add reset timeout to ColorPicker's copy functionality. (#34601) ...
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As outlined in #34283 when you add a new nav item the link UI only shows 3 initial search results. The same happens if you perform a search.
This PR amends the Nav Editor screen only to allow up to 10 search suggestion items to be displayed in the link UI. This provides more initial options for the user to choose from.
Ultimately we will also have the bulk addition UI to help make it easier to find and insert items but in the meantime this tweak should improve the UX.
Fixes #34283
How has this been tested?
Check this change has not impacted other editors/screens. Only the Nav Editor.
Screenshots
Screen.Capture.on.2021-09-14.at.13-38-41.mp4
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).