Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolsPanel component: refactor to typescript #34028

Merged
merged 22 commits into from
Sep 23, 2021
Merged

ToolsPanel component: refactor to typescript #34028

merged 22 commits into from
Sep 23, 2021
+339 −113

Commits on Sep 23, 2021

  1. Start refactor of ToolsPanel component to typescript

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    7e79847 View commit details
    Browse the repository at this point in the history

  2. Add typing for dropdown menu

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    b1e2fc0 View commit details
    Browse the repository at this point in the history

  3. Start typing the ToolsPanelHeader component

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    65fa4f6 View commit details
    Browse the repository at this point in the history

  4. Add types for ToolsPanelHeader

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    74ddbd8 View commit details
    Browse the repository at this point in the history

  5. Add remaining types

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    15c0ae3 View commit details
    Browse the repository at this point in the history

  6. More conflict resolution

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    336efba View commit details
    Browse the repository at this point in the history

  7. Update PolymorphicComponent* references to WordPressComponentProps*

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    a1fe287 View commit details
    Browse the repository at this point in the history

  8. Fix type issues following rebase

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    8d9d8d7 View commit details
    Browse the repository at this point in the history

  9. fix remaining menu item type issues

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    ee69bf8 View commit details
    Browse the repository at this point in the history

  10. Improve menu item types

    @aaronrobertshaw
    Glen Davies authored and aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    1174878 View commit details
    Browse the repository at this point in the history

  11. Move remaining eligible ToolsPanel files to TS

    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    19dec18 View commit details
    Browse the repository at this point in the history

  12. Revert "Improve menu item types" 

    This reverts commit 2676061.
    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    bb89386 View commit details
    Browse the repository at this point in the history

  13. Revert "Add typing for dropdown menu" 

    This reverts commit 81c0048.
    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    8369760 View commit details
    Browse the repository at this point in the history

  14. Remove menu group and item type doc block annotations

    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    d853e9a View commit details
    Browse the repository at this point in the history

  15. Add ts-nocheck to ToolsPanelHeader 

    The typing for DropdownMenu, MenuGroup and MenuItem will be handled separately and may entail a full TypeScript conversion rather than only doc block annotations.
    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    19bdce7 View commit details
    Browse the repository at this point in the history

  16. Move ts-nocheck to dependencies and fix type errors

    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    bce9e12 View commit details
    Browse the repository at this point in the history

  17. Improve typing of ToolsPanel 

    Removes redundant typing, improves naming and adds JSDocs etc
    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    87127db View commit details
    Browse the repository at this point in the history

  18. Add missing dependencies to tools panel item hook 

    In order to prevent excessive renders and guard against consumers not memoizing the hasValue and resetAllFilter functions, these changes include useCallback calls to handle this before adding them to the hook dependencies.
    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    6c4180e View commit details
    Browse the repository at this point in the history

  19. Use optional chaining for onSelect and onDeselect calls

    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    19cd494 View commit details
    Browse the repository at this point in the history

  20. Add TypeScript types for function props in READMEs

    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    f061db7 View commit details
    Browse the repository at this point in the history

  21. Enforce boolean for hasMenuItems in ToolsPanelContext

    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    d4674f1 View commit details
    Browse the repository at this point in the history

  22. Make all properties except panelId mandatory in ToolsPanelContext

    @aaronrobertshaw
    aaronrobertshaw committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    1f833ab View commit details
    Browse the repository at this point in the history