-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media&Text: round position attribute on focal point save #33915
Conversation
Hi, @walbo Sorry, it looks like this PR fell through the cracks. Do you mind rebasing this? I would be happy to help with testing 🙇 Thank you |
Yep 👍 Don't have time this week, but can fix it next week. Will tag you for a review when ready. |
9fe1ae3
to
682b46a
Compare
@Mamaduka Should be rebased and updated now. Sorry for the big changeset in the deprecated file. Made v1-v5 variables instead of having an huge array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @walbo!
The deprecation clean-up looks good.
I tested new deprecation with a few different block setups from the pattern library, and there are no issues ✅
Thanks for the review and the help on testing 👍 |
Description
Currently, the focal point is not rounded in the Media & text block. That makes the block markup contain styles with many decimal places.
This PR fixes the problem and adds deprecation logic to keep current blocks valid.
Same logic was added to the cover block in #19183
Fixes #33615
How has this been tested?
56.00000000000001% 56.99999999999999%
.56% 57%
.56% 57%
.Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).