Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try custom dialog for wide legacy widgets #33236

Closed
wants to merge 8 commits into from
Closed

Try custom dialog for wide legacy widgets #33236

wants to merge 8 commits into from

Commits on Jul 21, 2021

  1. Swap popover for useDialog

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    513faf5 View commit details
    Browse the repository at this point in the history

  2. Remove unstable forceXAlignment from Popover

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2daf585 View commit details
    Browse the repository at this point in the history

  3. Put dialog in popover slot and have it close on blur

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d498dca View commit details
    Browse the repository at this point in the history

  4. Keep dialog mounted and don’t hide preview for wide widgets

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a11c51c View commit details
    Browse the repository at this point in the history

  5. Add positioning for wide form dialog

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    fde1f3a View commit details
    Browse the repository at this point in the history

  6. Simplify wide dialog positioning hook and adjust styling

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2d02f12 View commit details
    Browse the repository at this point in the history

  7. Avoid mutation of props

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    f1463db View commit details
    Browse the repository at this point in the history

  8. Renames and cleanup

    @stokesman
    stokesman committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    8236655 View commit details
    Browse the repository at this point in the history