Group typographic block supports under a typography key
#32252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Feature] Block API
jorgefilipecosta
requested review from
ajitbohra,
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
jorgefilipecosta
force-pushed
the
update/typography-supports-shape
branch
from
996c585
to
0aaef20
Compare
|
Size Change: +84 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
oandregal
reviewed
May 27, 2021
oandregal
reviewed
May 27, 2021
| return; | ||
| } | ||
|
|
||
| $has_font_size_support = _wp_array_get( $typography_supports, array( 'fontSize' ), false ); |
There was a problem hiding this comment.
It looks like we miss here the check for the font family? It's pre-existing to this PR, so fine to add after as well.
oandregal
reviewed
May 27, 2021
lib/block-supports/typography.php
Outdated
| $has_font_family_support = _wp_array_get( $typography_supports, array( '__experimentalFontFamily' ), false ); | ||
| $has_font_style_support = _wp_array_get( $typography_supports, array( '__experimentalFontStyle' ), false ); | ||
| $has_font_weight_support = _wp_array_get( $typography_supports, array( '__experimentalFontWeight' ), false ); | ||
| $has_font_size_support = _wp_array_get( $typography_supports, array( 'fontSize' ), false ); |
There was a problem hiding this comment.
I liked that this list was alphabetized above :)
oandregal
reviewed
May 27, 2021
| $has_font_size_support = _wp_array_get( $typography_supports, array( 'fontSize' ), false ); | ||
| $has_line_height_support = _wp_array_get( $typography_supports, array( 'lineHeight' ), false ); | ||
| $has_text_decoration_support = _wp_array_get( $typography_supports, array( '__experimentalTextDecoration' ), false ); | ||
| $has_text_transform_support = _wp_array_get( $typography_supports, array( '__experimentalTextTransform' ), false ); | ||
|
|
||
| $skip_font_size_support_serialization = _wp_array_get( $block_type->supports, array( '__experimentalSkipFontSizeSerialization' ), false ); |
There was a problem hiding this comment.
Typography has two flags to skip serialization (__experimentalSkipFontSizeSerialization and __experimentalSkipTypographySerialization). The other properties have only one and are nested within the key itself (color.__experimentalSkipSerialization). As part of this consolidation, I think we'd want typography to behave the same. As long as both changes are part of the same plugin & WordPress release, I'm not opinionated on whether it should be done in this PR or in a quick follow-up.
oandregal
reviewed
May 27, 2021
lib/blocks.php
Outdated
| */ | ||
| function gutenberg_migrate_old_typography_shape( $metadata ) { | ||
| if ( isset( $metadata['supports'] ) ) { | ||
| $font_size_support = _wp_array_get( $metadata['supports'], array( 'fontSize' ), null ); |
There was a problem hiding this comment.
Would it make sense to migrate the experimental supports as well? I'd think it's not a lot of work and it'd be nice for developers to know what's happening and to maintain back-compatibility for a few versions.
oandregal
reviewed
May 27, 2021
lib/blocks.php
Outdated
| $font_size_support = _wp_array_get( $metadata['supports'], array( 'fontSize' ), null ); | ||
| $line_height_support = _wp_array_get( $metadata['supports'], array( 'lineHeight' ), null ); | ||
| if ( null !== $font_size_support ) { | ||
| trigger_error( |
There was a problem hiding this comment.
This is what I see using lates5.8-alpha-51034 (it doesn't happen on 5.7):
Peek.2021-05-27.12-30.mp4
Notice that I can't navigate anywhere 😅 Given the high usage of fontSize and lineHeight (which means a lot of messages) and that this migration makes everything work, is there a way to tone down the notifications a bit?
There was a problem hiding this comment.
That was happening because the core block.json files are not yet updated and are also processed by the filter. For now, I added a check to ignore core files until we update the core.
Squashed commits: [ce2c0f8856] Update lib/block-supports/typography.php Co-authored-by: André <nosolosw@users.noreply.github.com> [a27fe6e2c7] Update: Typography supports shape.
jorgefilipecosta
force-pushed
the
update/typography-supports-shape
branch
from
69ccf93
to
4d7dd83
Compare
|
Hi @nosolosw, your feedback was applied. The remaining task is updating skip serialization, I think we can do it in a separate quick PR to not increase this PR size. |
oandregal
approved these changes
Jun 2, 2021
|
@jorgefilipecosta I believe we'd want this one to be backported? If we don't, I'm not sure how 3rd party blocks can use the block supports mechanism without having those warning displayed. |
oandregal
added
the
Backport to WP 6.7 Beta/RC
oandregal
changed the title
typography key
|
Yes, this PR should be backported. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 7, 2021
Squashed commits: [ce2c0f8856] Update lib/block-supports/typography.php Co-authored-by: André <nosolosw@users.noreply.github.com> [a27fe6e2c7] Update: Typography supports shape.
youknowriad
pushed a commit
that referenced
this pull request
Jun 7, 2021
Squashed commits: [ce2c0f8856] Update lib/block-supports/typography.php Co-authored-by: André <nosolosw@users.noreply.github.com> [a27fe6e2c7] Update: Typography supports shape.
youknowriad
pushed a commit
to youknowriad/wordpress-develop
that referenced
this pull request
Jun 7, 2021
WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459 props jorgefilipecosta nosolosw
youknowriad
pushed a commit
to youknowriad/wordpress-develop
that referenced
this pull request
Jun 7, 2021
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jun 8, 2021
This includes the following fixes: Widgets Editor: - Load widgets.php WordPress/gutenberg#32299 - Fix Legacy Widget Preview WordPress/gutenberg#32300 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359 Widget blocks in the customizer: - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361 - Display wide widgets as popovers WordPress/gutenberg#31736 Global Styles: - Align classNames generation between client and server WordPress/gutenberg#32352 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404 Template Editor: - Update the appearance of the template details WordPress/gutenberg#32042 - Fix layout definition WordPress/gutenberg#32425 - Fix grouping post content block WordPress/gutenberg#32453 Miscellaneous: - Prevent saving when the post is locked WordPress/gutenberg#32341 - Fix allowed block patterns selector WordPress/gutenberg#32376 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344 - Fix notices position in top toolbar mode WordPress/gutenberg#32238 - Allow non-latin characters in post slugs WordPress/gutenberg#32232 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370 - Fix block alignment styles in the editor WordPress/gutenberg#32454 - Fix some block toolbar overlaps WordPress/gutenberg#32424 - Fix content loss when switching list types WordPress/gutenberg#32432 Performance: - Improve the performance of buttons block WordPress/gutenberg#32356 - Improve the performance of the container blocks WordPress/gutenberg#32380 Props noisysocks, nosolosw, jorgefilipecosta. See #52991. git-svn-id: https://develop.svn.wordpress.org/trunk@51089 602fd350-edb4-49c9-b593-d223f7449a82
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Jun 8, 2021
This includes the following fixes: Widgets Editor: - Load widgets.php WordPress/gutenberg#32299 - Fix Legacy Widget Preview WordPress/gutenberg#32300 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359 Widget blocks in the customizer: - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361 - Display wide widgets as popovers WordPress/gutenberg#31736 Global Styles: - Align classNames generation between client and server WordPress/gutenberg#32352 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404 Template Editor: - Update the appearance of the template details WordPress/gutenberg#32042 - Fix layout definition WordPress/gutenberg#32425 - Fix grouping post content block WordPress/gutenberg#32453 Miscellaneous: - Prevent saving when the post is locked WordPress/gutenberg#32341 - Fix allowed block patterns selector WordPress/gutenberg#32376 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344 - Fix notices position in top toolbar mode WordPress/gutenberg#32238 - Allow non-latin characters in post slugs WordPress/gutenberg#32232 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370 - Fix block alignment styles in the editor WordPress/gutenberg#32454 - Fix some block toolbar overlaps WordPress/gutenberg#32424 - Fix content loss when switching list types WordPress/gutenberg#32432 Performance: - Improve the performance of buttons block WordPress/gutenberg#32356 - Improve the performance of the container blocks WordPress/gutenberg#32380 Props noisysocks, nosolosw, jorgefilipecosta. See #52991. git-svn-id: https://develop.svn.wordpress.org/trunk@51089 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jun 8, 2021
This includes the following fixes: Widgets Editor: - Load widgets.php WordPress/gutenberg#32299 - Fix Legacy Widget Preview WordPress/gutenberg#32300 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359 Widget blocks in the customizer: - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361 - Display wide widgets as popovers WordPress/gutenberg#31736 Global Styles: - Align classNames generation between client and server WordPress/gutenberg#32352 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404 Template Editor: - Update the appearance of the template details WordPress/gutenberg#32042 - Fix layout definition WordPress/gutenberg#32425 - Fix grouping post content block WordPress/gutenberg#32453 Miscellaneous: - Prevent saving when the post is locked WordPress/gutenberg#32341 - Fix allowed block patterns selector WordPress/gutenberg#32376 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344 - Fix notices position in top toolbar mode WordPress/gutenberg#32238 - Allow non-latin characters in post slugs WordPress/gutenberg#32232 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370 - Fix block alignment styles in the editor WordPress/gutenberg#32454 - Fix some block toolbar overlaps WordPress/gutenberg#32424 - Fix content loss when switching list types WordPress/gutenberg#32432 Performance: - Improve the performance of buttons block WordPress/gutenberg#32356 - Improve the performance of the container blocks WordPress/gutenberg#32380 Props noisysocks, nosolosw, jorgefilipecosta. See #52991. Built from https://develop.svn.wordpress.org/trunk@51089 git-svn-id: http://core.svn.wordpress.org/trunk@50698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Jun 8, 2021
This includes the following fixes: Widgets Editor: - Load widgets.php WordPress/gutenberg#32299 - Fix Legacy Widget Preview WordPress/gutenberg#32300 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359 Widget blocks in the customizer: - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361 - Display wide widgets as popovers WordPress/gutenberg#31736 Global Styles: - Align classNames generation between client and server WordPress/gutenberg#32352 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404 Template Editor: - Update the appearance of the template details WordPress/gutenberg#32042 - Fix layout definition WordPress/gutenberg#32425 - Fix grouping post content block WordPress/gutenberg#32453 Miscellaneous: - Prevent saving when the post is locked WordPress/gutenberg#32341 - Fix allowed block patterns selector WordPress/gutenberg#32376 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344 - Fix notices position in top toolbar mode WordPress/gutenberg#32238 - Allow non-latin characters in post slugs WordPress/gutenberg#32232 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370 - Fix block alignment styles in the editor WordPress/gutenberg#32454 - Fix some block toolbar overlaps WordPress/gutenberg#32424 - Fix content loss when switching list types WordPress/gutenberg#32432 Performance: - Improve the performance of buttons block WordPress/gutenberg#32356 - Improve the performance of the container blocks WordPress/gutenberg#32380 Props noisysocks, nosolosw, jorgefilipecosta. See #52991. Built from https://develop.svn.wordpress.org/trunk@51089 git-svn-id: https://core.svn.wordpress.org/trunk@50698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
F-Wilke
pushed a commit
to FiliagoDev/WordPress
that referenced
this pull request
Jul 31, 2021
This includes the following fixes: Widgets Editor: - Load widgets.php WordPress/gutenberg#32299 - Fix Legacy Widget Preview WordPress/gutenberg#32300 - Fix error when saving empty Legacy Widget block WordPress/gutenberg#32359 Widget blocks in the customizer: - Fix deselection blocks when the inspector is open WordPress/gutenberg#32361 - Display wide widgets as popovers WordPress/gutenberg#31736 Global Styles: - Align classNames generation between client and server WordPress/gutenberg#32352 - Group typography block supports WordPress/gutenberg#32252 WordPress/gutenberg#32444 WordPress/gutenberg#32459 - Make theme.json syntax errors more visible to the users WordPress/gutenberg#32404 Template Editor: - Update the appearance of the template details WordPress/gutenberg#32042 - Fix layout definition WordPress/gutenberg#32425 - Fix grouping post content block WordPress/gutenberg#32453 Miscellaneous: - Prevent saving when the post is locked WordPress/gutenberg#32341 - Fix allowed block patterns selector WordPress/gutenberg#32376 - Fix wrong results in the Post Author picker WordPress/gutenberg#32344 - Fix notices position in top toolbar mode WordPress/gutenberg#32238 - Allow non-latin characters in post slugs WordPress/gutenberg#32232 - Fix Random collapse of the color settings panel WordPress/gutenberg#32388 - Fix theme logo theme mode not being removed on theme removal WordPress/gutenberg#32370 - Fix block alignment styles in the editor WordPress/gutenberg#32454 - Fix some block toolbar overlaps WordPress/gutenberg#32424 - Fix content loss when switching list types WordPress/gutenberg#32432 Performance: - Improve the performance of buttons block WordPress/gutenberg#32356 - Improve the performance of the container blocks WordPress/gutenberg#32380 Props noisysocks, nosolosw, jorgefilipecosta. See #52991. Built from https://develop.svn.wordpress.org/trunk@51089 git-svn-id: http://core.svn.wordpress.org/trunk@50698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
aaronrobertshaw
added a commit
that referenced
this pull request
Sep 2, 2021
Letter spacing support was missed when grouping the typography supports in #32252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the typography supports shape instead of having the keys at the top level we group them under typography as we do with colors, and similar to what we do on theme.json.
It introduces a mechanism that updates usages of the current shape to the new one and outputs a deprecation message.
There are pending documentation updates.
How has this been tested?
I verified in multiple blocks that the typography attributes still work ( tested at least one static block e.g: paragraph and one dynamic block like the post date).
I went to the global styles panel and verified the typography settings for block-specific styles still work.
I reverted the block.json of one of the blocks and verified the typography UI still appears and a deprecation message is output.