Block Supports: Allow skipping spacing support serialization #31973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
aaronrobertshaw
requested review from
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
aaronrobertshaw
commented
May 19, 2021
Comment on lines
-38
to
-39
| $has_padding_support = gutenberg_has_spacing_feature_support( $block_type, 'padding' ); | ||
| $has_margin_support = gutenberg_has_spacing_feature_support( $block_type, 'margin' ); |
There was a problem hiding this comment.
Removed gutenberg_has_spacing_feature_support as it was just a wrapper for gutenberg_block_has_support. Unless the support config is changed to allow all spacing support with a single boolean it isn't needed.
|
Size Change: +15 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
9 tasks
|
@aaronrobertshaw Is this updating
|
Fix dynamic block skip spacing support serialization check
aaronrobertshaw
force-pushed
the
add/skip-serialization-to-spacing-support
branch
from
51983c9
to
00d888d
Compare
My apologies @apeatling, I missed that I'd also updated I've just force pushed a rebase resolving the previous conflict in |
stacimc
approved these changes
May 23, 2021
There was a problem hiding this comment.
This looks great to me, and +1 for adding this support -- it will also be useful for adding padding to the button block.
In the testing instructions, in step 4:
Block should still visually update
I think this is saying that the block should still visually update for other controls like color, but padding/margin changes don't visually reflect since you've already enabled skip serialization in an earlier step. This tests correctly and is very clear from watching the testing gif you've supplied, just wanted to clarify for others testing!
Thanks @stacimc, you are correct, I've updated the test instructions. Appreciate you taking the time to review this.
As soon as we get the required approval I'll merge this. |
glendaviesnz
approved these changes
May 25, 2021
20 tasks
stacimc
pushed a commit
to stacimc/gutenberg
that referenced
this pull request
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #24874
Description
Background
As part of looking to add custom margins (gutters) to the column/s blocks, we run into an issue with the spacing block support styles being added as inline styles. This won't play nice with the CSS media queries that stack the columns at different viewports. These queries look to set a
flex-basisfor the column width taking into account margins so they stack correctly.This highlighted the fact that the option to skip serialization of the padding and margin block support styles wasn't available. This PR allows for that skipping of serialization.
How has this been tested?
Manually.
Test Notes
Test Instructions
customMarginunder thespacingsupport in your theme.jsonblock.jsonto enable both padding and margin support while skipping serialization - gistThe block's spacing shouldn't change although color selections etc should be applied and the block visually update
block.jsonfile to skip serialization (or any other dynamic block with spacing support) - gistScreenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).