FIX: Saving in Classic Editor shouldn't redirect to Gutenberg #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Sep 16, 2017
lib/register.php
Outdated
| @@ -221,6 +221,13 @@ function gutenberg_get_edit_post_url( $post_id ) { | |||
| * @return string Edit post link. | |||
| */ | |||
| function gutenberg_filter_edit_post_link( $url, $post_id, $context ) { | |||
| $sendback = wp_get_referer(); | |||
| if ( $sendback && ( | |||
| strpos( $sendback, 'post.php' ) !== false || | |||
There was a problem hiding this comment.
Should we be more specific about these referrers, in case post.php occurs as a suffix for a file, or query parameter, or otherwise? Maybe:
0 === strpos( parse_url( admin_url( 'post.php' ), PHP_URL_PATH ), $sendback )
lib/register.php
Outdated
| $sendback = wp_get_referer(); | ||
| if ( $sendback && ( | ||
| strpos( $sendback, 'post.php' ) !== false || | ||
| strpos( $sendback, 'post-new.php' ) !== false ) ) { |
There was a problem hiding this comment.
Should the space indenting here be a tab? It's not clear by the PHP standards, but the JavaScript standards are more specific about this case:
When a conditional is too long to fit on one line, successive lines must be indented one extra level to distinguish them from the body.
i.e.
if ( $sendback && (
strpos( $sendback, 'post.php' ) !== false ||
strpos( $sendback, 'post-new.php' ) !== false ) ) {
return $url;
}
`get_edit_post_link` is used in `post.php` to redirect when saving. See https://core.trac.wordpress.org/browser/trunk/src/wp-admin/post.php#L190 By checking to see if the referer is the classic editor, modification to the edit post link is preserved. Introduced in #1797 Fixes #2707
aduth
force-pushed
the
update/edit-post-links
branch
from
b9511b5
to
4abf259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_edit_post_linkis used inpost.phpto redirect when saving. See https://core.trac.wordpress.org/browser/trunk/src/wp-admin/post.php#L190By checking to see if the referer is the classic editor, modification to the edit post link is preserved.
Introduced in #1797
Fixes #2707